Hello Hans, 05.07.2017 21:47, Hans de Goede wrote: [Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp and behaviour changes in r67796, r67798 and r67802.] > Looks good, thanks I'm still going to go for compatibility > with the old behavior though, to ensure existing guest addition > installs keep working if they end up using the in kernel > vboxguest version. Do you agree that that is the right thing to do ? [...]Again, your choice but I personally don't think that it is worth it. Old Additions should always be installed with a matching kernel module, which in all recent versions should explicitly override any version supplied by the kernel. Any older versions are very unlikely to be run in conjunction with a recent kernel, because the included modules would not build against it, and the user would almost certainly upgrade.
Not to mention that the user-land parts might well not not work properly on a recent distribution; the Linux kernel is very careful about binary compatibility, but in practice old binaries are very unlikely to run on a recent Linux system because of the user-space parts. Which of course is one of our reasons-to-be in the first place. Regards Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher _______________________________________________ vbox-dev mailing list vbox-dev@virtualbox.org https://www.virtualbox.org/mailman/listinfo/vbox-dev