Hi John,

thanks for the report -- I'll take care of it.

--
Kind regards / Mit freundlichen Grüßen

******************************************************************
Andreas Löffler | VirtualBox Engineering
Principal Software Engineer | Oracle Virtualization

Oracle Global Services Germany GmbH
Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRB 246209
Geschäftsführer: Ralf Herrmann

Green Oracle <http://www.oracle.com/commitment> <http://www.oracle.com/commitment%3e>; Oracle is committed to developing practices and products that help protect the environment




On 15.01.23 17:19, John Lumby via vbox-dev wrote:
  src/VBox/Main/xml/Settings.cpp gets itself very confused 😜with its 
conditional pieces :


--- src/VBox/Main/xml/Settings.cpp.orig 2022-11-17 14:15:45.000000000 -0500
+++ src/VBox/Main/xml/Settings.cpp      2023-01-14 10:11:06.734739372 -0500
@@ -8936,15 +8936,19 @@ AudioDriverType_T MachineConfigFile::get
          if (RTProcIsRunningByName("pulseaudio") &&
              RTLdrIsLoadable("libpulse.so.0"))
              s_enmLinuxDriver = AudioDriverType_Pulse;
+#if defined(VBOX_WITH_AUDIO_ALSA) || defined(VBOX_WITH_AUDIO_OSS)
          else
+#endif
  # endif /* VBOX_WITH_AUDIO_PULSE */
  # ifdef VBOX_WITH_AUDIO_ALSA
              /* Check if we can load the ALSA library */
               if (RTLdrIsLoadable("libasound.so.2"))
                  s_enmLinuxDriver = AudioDriverType_ALSA;
+#if defined(VBOX_WITH_AUDIO_OSS)
+        else
+#endif
  # endif /* VBOX_WITH_AUDIO_ALSA */
  # ifdef VBOX_WITH_AUDIO_OSS
-             else
                  s_enmLinuxDriver = AudioDriverType_OSS;
  # endif /* VBOX_WITH_AUDIO_OSS */
      }


_______________________________________________
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Attachment: OpenPGP_0x46BCB4E5EE437BAD.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Reply via email to