> -----Messaggio originale-----
> Da: kbo [mailto:kbo]Per conto di Ken Jones
> Inviato: giovedi 8 marzo 2001 16.35
> A: Andrea Cerrito
> Cc: [EMAIL PROTECTED]
> Oggetto: Re: CODA and VPOPMAIL and link/rename
>
>
> This is really interesting. So CODA has problems with the link/unlink
> function but works okay with the rename function.
No. Just with link(). Here it is what a Coda developer said about the link
function: http://www.coda.cs.cmu.edu/maillists/codalist-2000/0719.html
> Hmm.. why not
> change all the link's in vpopmail to renames?
Done (see attached patch) and it appears to work. Anyway, I haven't tested
it a lot, but I think it's all ok (I mean, we are just changing the way
vpopmail move files, nothing else).
> Is there any major performance problem or other gotcha's we could
> run into if we switched the links to renames? If not, let's make
> the change.
I don't think there are performance issues, but security issue: qmail uses
link function in Maildir to be sure to successfully deliver mail even in
case of disk failure. I don't know how rename() can be in such situations.
> While we are at it. There is an fsync in vdelivermail.c. I don't
> really see a reason and it would just increase the disk I/O load.
Well, haven't looked at that. :)
---
Cordiali saluti / Best regards
Andrea Cerrito
^^^^^^^^^^^^^^
Net.Admin @ Centro MultiMediale di Terni SpA
P.zzale Bosco 3A
05100 Terni IT
Tel. 0744 / 5441330
Fax. 0744 / 5441372
ÿþ* * * v d e l i v e r m a i l . c . o l d T h u M a r 8
1 6 : 5 7 : 5 6 2 0 0 1
- - - v d e l i v e r m a i l . c T h u M a r 8
1 6 : 5 5 : 2 6 2 0 0 1
* * * * * * * * * * * * * * *
* * * 5 7 3 , 5 9 1 * * * *
i f ( h i t _ f i l t e r = = 1 ) {
d o _ f i l t e r _ d e l i v e r y (
t m p _ f i l e ) ;
} e l s e {
! i f
( l i n k ( t m p _ f i l e , m a i l n a m e ) = = - 1 ) {
d e l e t e _ t m p ( ) ;
f a i l t e m p ( " U n a b l e
t o l i n k t m p t o n e w ( # 4 . 3 . 7 ) \ n " ) ;
}
}
# e l s e
! i f ( l i n k ( t m p _ f i l e _ f , m a i l n a m e ) = =
- 1 ) {
d e l e t e _ t m p _ f ( ) ;
f a i l t e m p ( " U n a b l e t o l i n k
t m p t o n e w ( # 4 . 3 . 7 ) \ n " ) ;
}
# e n d i f
! d e l e t e _ t m p _ f ( ) ;
}
- - - 5 7 3 , 5 9 5 - - - -
i f ( h i t _ f i l t e r = = 1 ) {
d o _ f i l t e r _ d e l i v e r y (
t m p _ f i l e ) ;
} e l s e {
!
! / * U s i n g r e n a m e ( ) i n s t e a d o f l i n k ( ) d u e
t o C o d a f s . * /
! i f
( r e n a m e ( t m p _ f i l e , m a i l n a m e ) = = - 1 ) {
d e l e t e _ t m p ( ) ;
f a i l t e m p ( " U n a b l e
t o l i n k t m p t o n e w ( # 4 . 3 . 7 ) \ n " ) ;
}
}
# e l s e
! i f ( r e n a m e ( t m p _ f i l e _ f , m a i l n a m e ) = =
- 1 ) {
d e l e t e _ t m p _ f ( ) ;
f a i l t e m p ( " U n a b l e t o l i n k
t m p t o n e w ( # 4 . 3 . 7 ) \ n " ) ;
}
# e n d i f
! / * W e d o n ' t n e e d d e l e t e _ t m p _ f a n y m o r e ,
b e c a u s e r e n a m e ( ) " d e l e t e s " f i l e i n t m p /
d i r .
! d e l e t e _ t m p _ f ( ) ;
! * /
}
* * * * * * * * * * * * * * *
* * * 7 8 3 , 7 9 3 * * * *
d e l e t e _ t m p ( ) ;
f a i l t e m p ( " U n a b l e t o
c l o s e ( ) t m p f i l e ( # 4 . 3 . 6 ) \ n " ) ;
}
! i f ( l i n k ( t m p _ f i l e , m a i l n a m e ) = = - 1 )
{
d e l e t e _ t m p ( ) ;
f a i l t e m p ( " U n a b l e t o l i n k
t m p t o n e w ( # 4 . 3 . 7 ) \ n " ) ;
}
! d e l e t e _ t m p ( ) ;
# i f d e f H A R D _ Q U O T A
i f ( p w _ d a t a ! = N U L L & &
s s t r n c m p ( p w _ d a t a - > p w _ s h e l l , " N O " , 2 ) ! = 0 & &
- - - 7 8 7 , 7 9 7 - - - -
d e l e t e _ t m p ( ) ;
f a i l t e m p ( " U n a b l e t o
c l o s e ( ) t m p f i l e ( # 4 . 3 . 6 ) \ n " ) ;
}
! i f ( r e n a m e ( t m p _ f i l e , m a i l n a m e ) = =
- 1 ) {
d e l e t e _ t m p ( ) ;
f a i l t e m p ( " U n a b l e t o l i n k
t m p t o n e w ( # 4 . 3 . 7 ) \ n " ) ;
}
! / * d e l e t e _ t m p ( ) ; * /
# i f d e f H A R D _ Q U O T A
i f ( p w _ d a t a ! = N U L L & &
s s t r n c m p ( p w _ d a t a - > p w _ s h e l l , " N O " , 2 ) ! = 0 & &
* * * v p o p b u l l . c . o l d T h u M a r 8
1 6 : 5 8 : 3 1 2 0 0 1
- - - v p o p b u l l . c T h u M a r 8 1 6 : 5 7 : 2 8 2 0 0 1
* * * * * * * * * * * * * * *
* * * 2 2 3 , 2 2 9 * * * *
f c l o s e ( f s ) ;
} e l s e i f ( D e l i v e r y M e t h o d = =
H A R D _ L I N K _ I T ) {
s p r i n t f ( t m p b u f 1 , " % s / % s " ,
C u r D i r , E m a i l F i l e ) ;
! i f ( l i n k ( t m p b u f 1 ,
t m p b u f ) < 0 ) {
p e r r o r ( " l i n k " ) ;
}
} e l s e i f ( D e l i v e r y M e t h o d = =
S Y M B O L I C _ L I N K _ I T ) {
- - - 2 2 3 , 2 3 0 - - - -
f c l o s e ( f s ) ;
} e l s e i f ( D e l i v e r y M e t h o d = =
H A R D _ L I N K _ I T ) {
s p r i n t f ( t m p b u f 1 , " % s / % s " ,
C u r D i r , E m a i l F i l e ) ;
! / * U s i n g h a r d l i n k o n c o d a f s i s n ' t
a l l o w e d , s o w e c a n u s e t h e r e n a m e ( )
f u n c t i o n i n s t e a d . * /
! i f ( r e n a m e ( t m p b u f 1 ,
t m p b u f ) < 0 ) {
p e r r o r ( " l i n k " ) ;
}
} e l s e i f ( D e l i v e r y M e t h o d = =
S Y M B O L I C _ L I N K _ I T ) {
