-----BEGIN PGP SIGNED MESSAGE-----

Hello,
Glancing through the code, I found several occurrences of
lseek(0, SEEK_SET, 0L);
which normally should  work (if #define SEEK_SET 0 applies)
but nevertheless it is bad coding practice as:

     lseek(int fildes, off_t offset, int whence);
[...]
           If whence is SEEK_SET, the offset is set to offset bytes.

           If whence is SEEK_CUR, the offset is set to its current
location
           plus offset bytes.

           If whence is SEEK_END, the offset is set to the size of
the file
           plus offset bytes.


So I think it actually should read
lseek(0, 0L, SEEK_SET);






Best regards,
 Gabriel


-----BEGIN PGP SIGNATURE-----
Version: PGP 6.5i

iQEVAwUBO7sh0sZa2WpymlDxAQEt/wf+KkM5pN+fQ9PwO9hffK5f2/xEGIT7uSl7
2pv6f+zm9Ay0/Ry+IEJ5i3VgMtWRBzg/Yg9J9RNMwoxHns+SXYVN4fRUMUshcD96
BHmfErPq7Jae4B/hUesnfocf0u+iWTtPFhn1e05KVAf+9fC/3Rxjtd9E6FAvhB94
3dFxRRuKruoaW8TSSTsatLTECfM0NMuPkvfM+G+IAOF7ApkToGH0v2FJERWhHvxn
YeQo7AMQIaKSeSC3IH50k+ONrGccFX+/1bOgP07hhP9nxd0mdOfPlAkqDHBj6WQ1
5Wf5x9PD10smMzZI/guxsrR9HJY7BfL6KEfMkAzkdKiye6Yt4Cz+3A==
=AvNk
-----END PGP SIGNATURE-----

Reply via email to