Author: arkurth
Date: Mon May 21 15:13:36 2012
New Revision: 1341064
URL: http://svn.apache.org/viewvc?rev=1341064&view=rev
Log:
VCL-572
Added check to Windows.pm::install_updates to return immediately if no updates
were found on the management node to speed things up. It had been also
retrieving list of updates installed on the computer which was pointless if
nothing had to be installed.
Modified:
incubator/vcl/trunk/managementnode/lib/VCL/Module/OS/Windows.pm
Modified: incubator/vcl/trunk/managementnode/lib/VCL/Module/OS/Windows.pm
URL:
http://svn.apache.org/viewvc/incubator/vcl/trunk/managementnode/lib/VCL/Module/OS/Windows.pm?rev=1341064&r1=1341063&r2=1341064&view=diff
==============================================================================
--- incubator/vcl/trunk/managementnode/lib/VCL/Module/OS/Windows.pm (original)
+++ incubator/vcl/trunk/managementnode/lib/VCL/Module/OS/Windows.pm Mon May 21
15:13:36 2012
@@ -11071,11 +11071,19 @@ sub install_updates {
my $computer_node_name = $self->data->get_computer_node_name();
my $system32_path = $self->get_system32_path() || return;
+ my $image_name = $self->data->get_image_name();
# Get the node configuration directory, make sure it exists, create if
necessary
my $node_configuration_directory =
$self->get_node_configuration_directory();
my @computer_tools_files = $self->get_tools_file_paths("/Updates/");
+ if (@computer_tools_files) {
+ notify($ERRORS{'DEBUG'}, 0, scalar(@computer_tools_files) . "
updates found which apply to $image_name:\n" . join("\n",
@computer_tools_files));
+ }
+ else {
+ notify($ERRORS{'DEBUG'}, 0, "no updates have been saved to the
management node which apply to $image_name");
+ return 1;
+ }
my $logfile_directory_path =
"$node_configuration_directory/Logs/Updates";
$self->create_directory($logfile_directory_path);
