Bugs item #3117649, was opened at 2010-11-24 15:48
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=611248&aid=3117649&group_id=95403

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: vde_switch
Group: None
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Bas van Sisseren (sisseren)
Assigned to: Nobody/Anonymous (nobody)
Summary: 802.1q tagged vlan 4095 sometimes crashes vde-switch

Initial Comment:
Hello,

When the vde-switch receives a packet with 802.1q tagged vlan 4095 (yes, I
know, these packets shouldn't be on the network..), it looks up vlant[4095].
This sometimes triggers a segfault.

I would suggest you add a

  if (vlan >= NUMOFVLAN)
   return; /* discard unwanted packets */

between these lines

  vlan=((packet->data[0] << 8) + packet->data[1]) & 0xfff;

  if (! BA_CHECK(vlant[vlan].table,port))
    return; /*discard unwanted packets*/


Regards,

Bas van Sisseren


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-06-06 07:59

Message:
uwIrlz  <a href="http://hnljcdtnglla.com/";>hnljcdtnglla</a>,
[url=http://agmykafkmcok.com/]agmykafkmcok[/url],
[link=http://ytwskhtoulml.com/]ytwskhtoulml[/link],
http://lchhgvnihpch.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-06-06 07:59

Message:
uwIrlz  <a href="http://hnljcdtnglla.com/";>hnljcdtnglla</a>,
[url=http://agmykafkmcok.com/]agmykafkmcok[/url],
[link=http://ytwskhtoulml.com/]ytwskhtoulml[/link],
http://lchhgvnihpch.com/

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2011-04-08 07:02

Message:
Dpgs1Y  <a href="http://znrqpddsyefq.com/";>znrqpddsyefq</a>,
[url=http://imclzrtavpdh.com/]imclzrtavpdh[/url],
[link=http://atrbtyflgumm.com/]atrbtyflgumm[/link],
http://faipwvpybwtc.com/

----------------------------------------------------------------------

Comment By: renzo davoli (rd235)
Date: 2011-02-14 15:15

Message:
It is true: those packets should not exist on a net but in case those
packets can kill a vde_switch. i.e. the switch is prone to a denial of
service attack).
I have solved the problem in the svn by adding a dummy element (#4095) on
the vlant array.
I have decided to waste 4 extra words of memory instead of one instruction
that would have been executed for each packet (complexity in space is
cheaper than complexity in time ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=611248&aid=3117649&group_id=95403

------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Discover what all the cheering's about.
Get your free trial download today. 
http://p.sf.net/sfu/quest-dev2dev2 
_______________________________________________
vde-users mailing list
vde-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/vde-users

Reply via email to