On 23.03.2013 17:14, Lucian Muresan wrote:

thank you Klaus for holding up your release plan for 2.0!
However, I hope this minor patch won't be too much trouble for you, as
it only increases the limit of 16 to theme and skin names, letting them
be NAME_MAX as almost any files, since these names can also be involved
in file names.
Was there a good reason to limit them at 16 only, perhaps the fear that
the name won't fit on the OSD? I don't really think someone would really
make use of as many as 255 characters for this. On the other hand, users
just encountered crashes with plugins which (unfortunately, yet) have
themes of their own, when just adding a new theme with a name longer
than 16 and at the same time the original plugin author relied on
MaxThemeName when allocating the string length.

Those are bugs in the plugins and should be fixed there.
Or is this something that can also happen in the core VDR?

So, what do you think, easy to adopt?

Well, for one, now is definitely not the right time for a change like this!
And furthermore, skin and theme names should be short. What sense does it
make to call a theme something like "This is the theme that implements a range
of colors from 400 nanometers to 700 nanometers", when you could just plain
simple call it "rainbow"? ;-)

So I'd say the limit is there for a reason, and should stay there.


vdr mailing list

Reply via email to