Hi, IMHO skincurses plugin also does not compile:
*** Plugin skincurses:
...
...
skincurses.c:In member function ‘virtual void
cSkinCursesDisplayTracks::SetAudioChannel(int)’:
skincurses.c:650:52:error: ‘override’ was not declared in this scope;
did you mean ‘overwrite’?
650 | virtual void SetAudioChannel(int AudioChannel) { override}
| ^~~~~~~~
| overwrite
skincurses.c:In member function ‘virtual const char*
cPluginSkinCurses::MainMenuEntry()’:
skincurses.c:802:72:error: ‘override’ was not declared in this scope;
did you mean ‘overwrite’?
802 | virtual const char *MainMenuEntry(void) { return
tr(MAINMENUENTRY); override}
| ^~~~~~~~
| overwrite
Greetings from Berlin
Martin
Am 13.04.25 um 16:01 schrieb Marko Mäkelä:
Sat, Apr 12, 2025 at 12:46:46PM +0200, Klaus Schmidinger wrote:
Added the "override" keyword to virtual functions reimplemented in
derived classes.
This C++11 keyword is misplaced in the plugin "hello". Here is the
first misplaced occurrence:
hello.c: In member function ‘virtual const char*
cPluginHello::Version()’:
hello.c:27:56: error: ‘override’ was not declared in this scope
27 | virtual const char *Version(void) { return VERSION; override}
The keyword "override" should occur before the function body, not in
the body. To my understanding, the keyword "virtual" is redundant and
could be removed, because "override" alone should imply that it is a
virtual member function.
Other than this, I was able to build and install the upgrade.
With best regards,
Marko
