On Sun, Mar 04, 2012 at 12:40:47AM +0200, Itamar Heim wrote: > On 03/04/2012 12:36 AM, Dan Kenigsberg wrote: > >On Fri, Mar 02, 2012 at 09:49:10AM +0200, Itamar Heim wrote: > >>On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: > >>>On Thu, Mar 01, 2012 at 03:18:59PM +0000, Itzik Brown wrote: > >>>>I have a problem building vdsm on RHEL 6.2 > >>>> > >>>>After running the following: > >>>> > >>>># git clone http://gerrit.ovirt.org/p/vdsm.git > >>>># cd vdsm > >>>># git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5&& git > >>>>checkout FETCH_HEAD > >>>># ./autobuild.sh > >> > >>cc-ing eyal - lets make sure we have a jenkins job running > >>./autobuild.sh on master (if not already)? > > > >Just make sure *not* to automatically run any code posted to gerrit. > >You can run pyflakes *on* it, but blind 'make' before human review invites > >evil > >posters. > > that's true in general. > but would we want to pre-approve patch senders? > or maybe only run make (for engine as well) if submitter is in a > white-list of sorts in jenkins?
I suppose we can trust anyone who already contributed to Vdsm, but there is still a chance of a lost laptop leading to our jenkins server running arbitrary code. Maybe we should forget about whitelisting, and use expendible network-less VMs to run whatever test jenkins runs on unreviewed code. _______________________________________________ vdsm-devel mailing list firstname.lastname@example.org https://fedorahosted.org/mailman/listinfo/vdsm-devel