----- Original Message -----
> I added the VmStatsThread to the ignored class list (see conf file
> here -> http://jenkins.ovirt.org/userContent/pylint.conf).
> 
> you can add more classes to that file if you think they should be
> ignored.

Please ignore this error in all modules as it is wrong in at least 99% of the 
cases.

> 
> i added it to this section:
> 
> [TYPECHECK]
> 
> .......
> 
> # List of classes names for which member attributes should not be
> checked
> # (useful for classes with attributes dynamically set).
> ignored-classes=hashlib,GenericHolder,VmStatsThread
> 
> 
> Eyal.
> 
> ----- Original Message -----
> > From: "Ayal Baron" <aba...@redhat.com>
> > To: "Eyal Edri" <ee...@redhat.com>
> > Cc: "vdsm-devel" <vdsm-de...@fedorahosted.org>, "Saggi Mizrahi"
> > <smizr...@redhat.com>
> > Sent: Wednesday, March 28, 2012 6:46:51 PM
> > Subject: Re: [vdsm] [oVirt Jenkins] vdsm_check_code_violations -
> > Build # 33  - Still Failing!
> > 
> > 
> > 
> > ----- Original Message -----
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Saggi Mizrahi" <smizr...@redhat.com>
> > > > To: "Ayal Baron" <aba...@redhat.com>
> > > > Cc: "vdsm-devel" <vdsm-de...@fedorahosted.org>, "Eyal Edri"
> > > > <ee...@redhat.com>
> > > > Sent: Thursday, March 22, 2012 6:12:08 PM
> > > > Subject: Re: [vdsm] [oVirt Jenkins] vdsm_check_code_violations
> > > > -
> > > > Build # 33      - Still Failing!
> > > > 
> > > > I already looked into this, pyflakes has no config files. You
> > > > need
> > > > to
> > > > build you own thing that filters it's errors.
> > > > 
> > > > I would suggest using pylint but our code is too messed up to
> > > > be
> > > > able
> > > > to run pylint properly because it actually imports modules and
> > > > how
> > > > the files are laid out in VDSM. But then again maybe we just
> > > > need
> > > > to
> > > > fix that anyway.
> > > 
> > > the job doesn't run pyflakes,
> > > it runs 'pylint -E -f parseable > pylint.txt'
> > > you can add the --rcfile for a custom conf file with exceptions
> > > and
> > > filters.
> > 
> > Please add the filters to the two error types I mentioned below
> > after
> > which we will be able to better examine what is left.
> > 
> > Thanks.
> > 
> > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Ayal Baron" <aba...@redhat.com>
> > > > > To: "Eyal Edri" <ee...@redhat.com>
> > > > > Cc: "vdsm-devel" <vdsm-de...@fedorahosted.org>
> > > > > Sent: Thursday, March 22, 2012 11:18:15 AM
> > > > > Subject: Re: [vdsm] [oVirt Jenkins]
> > > > > vdsm_check_code_violations
> > > > > -
> > > > > Build # 33    - Still Failing!
> > > > > 
> > > > > 
> > > > > 
> > > > > ----- Original Message -----
> > > > > > From: "Jenkins oVirt Server" <jenk...@ovirt.org>
> > > > > > To: aba...@redhat.com, vdsm-patc...@lists.fedorahosted.org,
> > > > > > dan...@redhat.com, fsimo...@redhat.com
> > > > > > Sent: Tuesday, March 20, 2012 6:38:17 PM
> > > > > > Subject: [oVirt Jenkins] vdsm_check_code_violations - Build
> > > > > > #
> > > > > > 33
> > > > > > -
> > > > > > Still Failing!
> > > > > > 
> > > > > > vdsm_check_code_violations - Build # 33 - Still Failing:
> > > > > > 
> > > > > > Check console output at
> > > > > > http://jenkins.ovirt.org/job/vdsm_check_code_violations/33/console
> > > > > > to view the results.
> > > > > > 
> > > > > 
> > > > > I reviewed the errors and the code, I couldn't find even one
> > > > > thing
> > > > > that is real (went through the first ~100 errors).
> > > > > We need a conf file to filter these error types:
> > > > > 
> > > > > Instance of 'VmStatsThread' has no 'addStatsFunction' member
> > > > > Passing unexpected keyword argument '__securityOverride' in
> > > > > function
> > > > > call
> > > > > _______________________________________________
> > > > > vdsm-devel mailing list
> > > > > vdsm-devel@lists.fedorahosted.org
> > > > > https://fedorahosted.org/mailman/listinfo/vdsm-devel
> > > > > 
> > > > 
> > > 
> > 
> 
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to