Dan,

Thanks for your work to merge these files. I notice that there are three files conflicting with the master branch not yet merged. It is because the change these files are big and not synced and get a higher possibility to conflict with other changes. In order to save both the maintainers and the submitter's time, I think we should have a protocol to merge these big files. If the maintainer think the files are ready, the maintainer should inform the submitter to rebase the patches with the latest master head in one day(considering the time zone difference, one day is a must). Also, it is the submitter's responsibility to rebase the patches time to time, but not necessary every day.

Pending files:
a3cda3e Make vdsm/caps.py PEP8 clean    Zhengsheng
b2cb196 Make vdsm/clientIF.py PEP8 clean    Zhengsheng
970c465 Make vdsm/guestIF.py PEP8 clean    Zhengsheng



On 2012-6-14 2:35, dan...@redhat.com wrote:
Dan Kenigsberg has posted comments on this change.

Change subject: Make vdsm/caps.py PEP8 clean
......................................................................


Patch Set 3: I would prefer that you didn't submit this

currently requires non-trivial rebase.

and btw, sorry of the excessive noise of my scripted push of former patches.

--
To view, visit http://gerrit.ovirt.org/4801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming<shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg<dan...@redhat.com>
Gerrit-Reviewer: Shu Ming<shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng<zhshz...@linux.vnet.ibm.com>



--
Shu Ming<shum...@linux.vnet.ibm.com>
IBM China Systems and Technology Laboratory


_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to