* Itamar Heim <ih...@redhat.com> [2012-05-16 10:26]:
> On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
> >On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
> >>* Dan Kenigsberg<dan...@redhat.com>  [2012-05-07 05:42]:
> >>>On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
> >>>>On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
> >>>>>On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
> >>>>>>Hi all,
> >>>>>>
> >>>>>>I would like to discuss the following on today's call:
> >>>>>>
> >>>>>>1. Gerrit vs. mailing list
> >>>>
> >>>>Gerrit is an inhibiter for some contributors.
> >>>>One approach to solve this improve gerrit:
> >>>>- Gerrit should send the patch when it notified of a change. This may
> >>>>   attract more reviewers.
> >>>
> >>>I'm happy to inform that Gal has sent a patch for this to upstream
> >>>gerrit:
> >>>https://gerrit-review.googlesource.com/#/c/34861/
> >>>Add unified diff to newchange mail template.
> >>>
> >>
> >>Any eta on getting the gerrit notifications of changes to include the
> >>full patch in the email?
> >
> >You can +1 them in googlesource, maybe it helps ;-)
> 
> indeed, please help push them upstream...
> https://gerrit-review.googlesource.com/#/c/34861/
> https://gerrit-review.googlesource.com/#/c/34862/
> 
> >
> >>
> >>I'm definitely happy to see notification on new posts and changes; helps
> >>me see what new activity is happening, but I'd really enjoy seeing the
> >>the patch series attached (via threading) as well.
> >
> >Itamar, I know Red Hat hates to do it, but can we take these patches to
> >ovirt's gerrit before they are accepted upstream?
> 
> yes we can.
> after i'll upgrade it to 2.3, which i prefer to do after i return
> from PTO in case there are some issues with the upgrade.
> so ETA end of the month for clean upgrade to 2.3, then after we see
> all is ok, let's say another week to upgrade to the version with
> these patches.

It's about 6 weeks later.  Dan's been asking for more review in vdsm;
I know that I'd be able to review quite a bit more if I can get patches
via email instead of the webui.

Can we get this enabled?


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ry...@us.ibm.com

_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to