----- Original Message -----
> From: "Federico Simoncelli" <fsimo...@redhat.com>
> To: "Alon Bar-Lev" <alo...@redhat.com>
> Cc: vdsm-devel@lists.fedorahosted.org, "Itzik Brown" <itz...@mellanox.com>
> Sent: Thursday, September 20, 2012 1:38:23 PM
> Subject: Re: [vdsm] Problem building vdsm RPM
> 
> ----- Original Message -----
> > From: "Alon Bar-Lev" <alo...@redhat.com>
> > To: "Federico Simoncelli" <fsimo...@redhat.com>
> > Cc: vdsm-devel@lists.fedorahosted.org, "Itzik Brown"
> > <itz...@mellanox.com>
> > Sent: Thursday, September 20, 2012 12:12:28 PM
> > Subject: Re: [vdsm] Problem building vdsm RPM
> > 
> > ----- Original Message -----
> > > From: "Federico Simoncelli" <fsimo...@redhat.com>
> > > To: "Alon Bar-Lev" <alo...@redhat.com>
> > > Cc: vdsm-devel@lists.fedorahosted.org, "Itzik Brown"
> > > <itz...@mellanox.com>
> > > Sent: Thursday, September 20, 2012 1:06:53 PM
> > > Subject: Re: [vdsm] Problem building vdsm RPM
> > > 
> > > ----- Original Message -----
> > > > From: "Alon Bar-Lev" <alo...@redhat.com>
> > > > To: "Itzik Brown" <itz...@mellanox.com>
> > > > Cc: vdsm-devel@lists.fedorahosted.org
> > > > Sent: Wednesday, September 19, 2012 4:18:08 PM
> > > > Subject: Re: [vdsm] Problem building vdsm RPM
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Itzik Brown" <itz...@mellanox.com>
> > > > > To: vdsm-devel@lists.fedorahosted.org
> > > > > Sent: Wednesday, September 19, 2012 5:12:28 PM
> > > > > Subject: [vdsm] Problem building vdsm RPM
> > > > > 
> > > > > 
> > > > > I'm trying to build vdsm from git . After make rpm I get
> > > > > these
> > > > > errors:
> > > > 
> > > > <snip>
> > > > 
> > > > How exactly do you try to build?
> > > > 
> > > > This is what working for me:
> > > > 
> > > > $ git clone ...
> > > > $ cd vdsm
> > > > $ autoreconf -ivf
> > > > $ ./configure
> > > > $ make dist
> > > > $ rpmbuild -tb vdsm*.gz
> > > 
> > > The suggested way of building vdsm is:
> > > 
> > > (clone and cd vdsm)
> > > $ ./autogen.sh --system
> > > $ make rpm
> > 
> > No reason for the --system, as rpmbuild will execute configure with
> > right settings.
> 
> Correct, but since you have to run it why keeping different (wrong)
> settings locally (vs. the ones that you'll be using in the rpm)?
> 
> > Also, in most projects autogen does not run configure... this is
> > something unique in vdsm I like to avoid.
> 
> Taken from libvirt, I don't see value in de-automating things.
> 
> > If there is a problem with rpmbuild -tb tarball, we need to fix
> > it...
> > is there any?
> 
> The problem with your rpmbuild command is that it's not automatic
> enough,
> if you want to automate it you use wildcards (vdsm*.gz) which will
> build
> any vdsm tar.gz you find in the directory rather the one you just
> prepared
> (which is what make rpm is doing).
> 
> It's not that what you're saying is wrong (after all it's what
> autogen.sh
> and the Makefile rely upon, and it works for you), it's that what you
> do
> manually is already done automatically (with less potential errors
> and
> confusion for the newcomers).

Well, my view is that there is a standard method of creating rpms out of source 
tree.

Newcomers that have done this on one project can reuse their knowledge to do 
this in another project.

There is no need to create custom unique methods to confuse people.

Regards,
Alon.
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to