* Alon Bar-Lev <alo...@redhat.com> [2012-09-27 13:38]:
> Alon Bar-Lev has posted comments on this change.
> 
> Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
> ......................................................................
> 
> 
> Patch Set 2:
> 
> Ok... I was discussing... I think that if you don't get +1 from parties you 
> should wait... :)
> 
> I see -1 as final decision... for the entire change... or if contributer is 
> not cooperating.
> 

I'm interested in a little clarity here.

As I see it, -1 means you don't want the current version submitted.

I like the idea of putting a patch on hold while various issues are
discussed, and it seems like a -1 is the right idea here since the
submitter can reply and original reviewer can re-review and remove a -1
if the submitter has fully explained the issue.  Additionaly the
submitter can resubmit with changes (and the -1 is removed anyhow).

What is the maintainer view of how best to use -1?  And if we don't use
a -1, how does one do the above?


> --
> To view, visit http://gerrit.ovirt.org/8206
> To unsubscribe, visit http://gerrit.ovirt.org/settings
> 
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I1019690e4a27caeff923655f9562892ce7f909af
> Gerrit-PatchSet: 2
> Gerrit-Project: vdsm
> Gerrit-Branch: master
> Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
> _______________________________________________
> vdsm-patches mailing list
> vdsm-patc...@lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ry...@us.ibm.com

_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to