master:
http://gerrit.ovirt.org/#/c/23044/

ovirt-3.3:
http://gerrit.ovirt.org/#/c/23045/

Assaf Muller, Cloud Networking Engineer 
Red Hat 


----- Original Message -----
From: "Assaf Muller" <amul...@redhat.com>
To: "Balamurugan Arumugam" <barum...@redhat.com>, "Dan Kenigsberg" 
<dan...@redhat.com>
Cc: "VDSM Project Development" <vdsm-devel@lists.fedorahosted.org>
Sent: Tuesday, January 7, 2014 4:04:18 PM
Subject: Re: [vdsm] gluster verbs are broken due to missing updateTimestamp()

This regression was introduced by (my) patch:
http://gerrit.ovirt.org/#/c/22837/3/vdsm/BindingXMLRPC.py

Which was recently merged to master.

You can see how updateTimestamp() is implemented at:
BindingXMLRPC.py, line 83. (A dummy/blank implementation would not work).

There's several approaches to solve this, I think the correct way would be
to make updateTimestamp a class method of the BindingXMLRPC class, and change
the calls from im_self to BindingXMLRPC.updateTimestamp. That way it doesn't
matter which method wrapApiMethod wraps, or what class defined the method,
it'll 'just work'.

I'll send a patch ASAP.


Assaf Muller, Cloud Networking Engineer 
Red Hat 

----- Original Message -----
From: "Balamurugan Arumugam" <barum...@redhat.com>
To: "Nir Soffer" <nsof...@redhat.com>
Cc: "VDSM Project Development" <vdsm-devel@lists.fedorahosted.org>
Sent: Tuesday, January 7, 2014 3:40:53 PM
Subject: [vdsm] gluster verbs are broken due to missing updateTimestamp()


Hi,

I see vdsm master is broken wrt gluster verbs.  When I run any gluster verbs, 
it errors out

Traceback (most recent call last):
File "/usr/share/vdsm/BindingXMLRPC.py", line 941, in wrapper
f.im_self.updateTimestamp()
AttributeError: 'GlusterApi' object has no attribute 'updateTimestamp'

I added a dummy updateTimestamp() in gluster.api.GlusterApi which resolves the 
issue, but I am not sure whether its correct or not.

Could you provide some info on updateTimestamp() and whether its applicable to 
gluster module?

Regards,
Bala
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to