On 01/16/2014 10:52 AM, Yedidyah Bar David wrote:
----- Original Message -----
From: "Vinzenz Feenstra" <vfeen...@redhat.com>
To: "Itamar Heim" <ih...@redhat.com>, vdsm-devel@lists.fedorahosted.org,
"engine-devel" <engine-de...@ovirt.org>
Sent: Thursday, January 16, 2014 11:40:01 AM
Subject: Re: [Engine-devel] Gerrit NEW Change Screen
On 01/16/2014 10:38 AM, Vinzenz Feenstra wrote:
On 01/15/2014 11:08 PM, Itamar Heim wrote:
with gerrit 2.8, there is a new change screen.
its not enabled by default (yet), please use and see what you think.
to enable, go to settings (click the top-right arrow next to your
name, and choose settings).
select preferences and set "Change View:" to "New Screen".
Well I had this enabled for some time today but I had to switch back,
since I don't see how I am able to apply code review +/- or anything
like this.
Correction, I just found it. It's hidden under the "Reply..." button
And if you hover on it you see that you can also press 'a'. In 2.6 'r'
did this, not sure why they had to change that. And if you press 'r'
inside a diff you get to the old review/reply page...
On the other hand, it is way faster on the diff view even for vdsm's
vm.py which has a whopping 5k lines. I like that :-)
This new change screen is something one really needs to get used to.
Indeed.
One thing I like in it is that in "History" it shows also all the inline
comments.
And one thing I miss is a solution to [1] - am I the only one bugged by it?
No, I am also not a big fan about it, but this is not a regression to
the previous version, thanks for the link :-)
[1] http://code.google.com/p/gerrit/issues/detail?id=217
--
Regards,
Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: +420 532 294 625
IRC: vfeenstr or evilissimo
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
