On Sun, Mar 02, 2014 at 12:01:21PM +0200, Yaniv Bronhaim wrote:
> In python's thread package implementation thread.allocate_lock is being used
> in each creation of new thread (python.__bootstrap_inner).
> Vdsm faced few scenarios where the thread run was stuck in this function.
> We assume that this lock implementation contains a deadlock bug. Therefore

I did not see enough evidence for this assumption, however, using
pthreading.Lock everywhere is just cleaner. Could you say "we suspect"
instead?

> this patch replaces thread.allocate_lock with python-pthreading Lock object
> (which uses pthread mutex).

python-pthreading Lock -> pthreading.Lock


Other than this - ACK. Please take it into git.

_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to