> On Wed, Mar 19, 2014 at 08:04:18AM -0400, Francesco Romani wrote: > > another cpickle patch round. http://paste.fedoraproject.org/86653/ > > The only change is: > > - DO NOT restart vdsmd between runs (just because it was faster to test) > > > > the timings/profile is now much more closer to what I was expecting. > > The benefits of switching to cPickle are indeed small, but the change is > > quick easy and safe, so I'm still all for it. > > I'm confused. What is the numerical benefit? > http://paste.fedoraproject.org/86611/ suggests that it's 36/1230=3% of > GIL-holding time, but the former pastebin saw a total *worsening*.
I improved my benchmarking script (https://gist.github.com/mojaves/9641520) so I can now gather more samples automatically. The only caveat is vdsmd is no restarted between runs, but I did this only as cautionary move and it should not be relevant. I'm closely following this issue. Let me gather some more data and then we can discuss and figure out what's going on here. -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
