Dan Kenigsberg has posted comments on this change.
Change subject: Recreate the run paths when needed
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
according Filesystem Hierarchy Standard, /var/run/ should not survive reboot.
Vdsm adheres to that and does not use it for persisted information.
/var/run/vdsm/pools directory is kept only for spm-induced restart, and
intentionally not persisted.
....................................................
File vdsm/vdsmd.in
Line 97: for run_path in "@VDSMRUNDIR@" "@POOLSDIR@"; do
Line 98: /bin/mkdir -p "$run_path"
Line 99: /bin/chmod 755 "$run_path"
Line 100: /bin/chown vdsm.kvm "$run_path"
Line 101: done
shouldn't you also restorecon for these dirs, to make sure SELinux is happy? Or
the default is fine as it is?
Line 102: }
Line 103:
Line 104: get_libvirt_conf_item() {
Line 105: local cfile key
--
To view, visit http://gerrit.usersys.redhat.com/1030
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6eee71ce11e47a64bf825089445d6ef4ec504d82
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
