Saggi Mizrahi has posted comments on this change. Change subject: Merged SPM to StoragePool and HSM ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 1317: return self.masterDomain.getVersion() Line 1318: Line 1319: def getSpmId(self): Line 1320: spmid = self.getMetaParam(PMDK_SPM_ID) Line 1321: if spmid != self.id or self.spmRole != SPM_FREE: No, I didn't I commented on the previous commit but I'll repeat myself. I DID NOT change the meaning code. Because spm held some SP functionality this method was written twice once in SP and once in SPM where in SPM it had this extra bit because SPM knew the role. Theses methods got unified when spm was merged in. Another proof that SPM class was a bad idea Line 1322: return spmid Line 1323: Line 1324: # If we claim to be the SPM we have to be really sure we are Line 1325: self.invalidateMetadata() -- To view, visit http://gerrit.usersys.redhat.com/1006 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia016ba62a9436dd4f655bddc0921d60f5211781b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
