Igor Lvovsky has posted comments on this change.
Change subject: Adding shared raw disk feature.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/clientIF.py
Line 580: try:
Line 581: result = self.irs.teardownVolume(drive['domainID'],
drive['poolID'],
Line 582: drive['imageID'],
drive['volumeID'])
Line 583: except KeyError:
Line 584: self.log.info("Avoiding tear down drive %s",
str(drive))
why 'avoiding'?
you just failed to teardown, didn't you?
should be an error.
Line 585:
Line 586: return result['status']['code']
Line 587:
Line 588: def create(self, vmParams):
--
To view, visit http://gerrit.usersys.redhat.com/1064
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo Warszawski <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
