Dan Kenigsberg has posted comments on this change.
Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
....................................................
Commit Message
Line 8:
please add the motivation for this:
We would like to pre-allocate metadata space in all PVs used for our VGs,
however, we are using only the metadata of the first PV. This is important for
an occasion where the first PV has to be removed and the metadata it carries
has to be copied into somewhere else.
Could not have been done without Haim's help.
....................................................
File vdsm/storage/lvm.py
Line 718: cmd = ["pvcreate", "--metadatasize", metadatasize,
"--metadatacopies", "2", "--metadataignore", "y"]
ELONGLINE
Line 730: raise se.PhysDevInitializationError("found: %s notFound:
%s", found, notFound)
ELONGLINE
Line 750: def arePartOfVg(pvNames):
vgsOfReachablePvs()
(or find a less-bad name)
"""Return ({pv: vg}, (pv...)) of reachable (and non-reachable pvs)"""
I prefer a more specific function "getUnavalablePvsForVgs"
that returns a list of "bad" pvs.
--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
