Dan Kenigsberg has posted comments on this change. Change subject: create /rhev repository ......................................................................
Patch Set 10: I would prefer that you didn't submit this (1 inline comment) a very minor comment. .................................................... File vdsm/storage/fileVolume.py Line 27: from os.path import normpath I really want to take this patch, but your import style is wrong: first import standard modules, then distribution modules, then local ones. In other word - push normpath to the first stanza above. -- To view, visit http://gerrit.ovirt.org/548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I971a7b47e834d7b6b95874ff6437e66b1928fc82 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
