Federico Simoncelli has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 16: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/domainMonitor.py
Line 44: # warning mechanizm.
mechanism
Line 126: try:
The try/except block should protect the onDomainConnectivityStateChange.emit
part only.
Line 128: self.log.debug("Domain `%s` changed its status to
%s", domain.sdUUID, {True:"valid", False:"Invalid"}[nextStatus.valid])
Spaces, case consistency and 80 columns. We might want the True/False
dictionary as constant somewhere in the module/class.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
