Federico Simoncelli has posted comments on this change. Change subject: Implement VMs live snapshots ......................................................................
Patch Set 9: (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 1421: self.saveState() What else can we do here? The change already happened and we're trying to update our information, if this fails we can't try to rollback. Moreover this "fails" only if we can't find the drives (which means we have a bug somewhere else). -- To view, visit http://gerrit.ovirt.org/469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
