Dan Kenigsberg has posted comments on this change. Change subject: Change safelease APIs to match SANLock flow ......................................................................
Patch Set 9: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 921: # since the domain will be deactivated this seems unrelated to the API change. wouldn't it be slightly safer to first stop spm and only then umount? -- To view, visit http://gerrit.ovirt.org/221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39d5410ad76b22b037e8cac7e667817fb9ef56f6 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
