Dan Kenigsberg has posted comments on this change.
Change subject: add/del network - add bridgesless network
......................................................................
Patch Set 14: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/clientIF.py
Line 118: configNetwork.createLibvirtNetwork(network=bridge,
bridged=True, iface=None)
it would be nicer if iface was None by default
....................................................
File vdsm/netinfo.py
Line 247: for netname in nets.keys():
iterkeys() is cooler
Line 248: d['networks'][netname] = {}
I find that building a dictionary like that is cumbersome. why not have
if nets[netname]['bridged']:
d['networks'][netname] = {ports:, stp....}
else
d['networks'][netname] = {interface:}
Line 281: for vlan in vlans() ])
I originally thought that we'd have a new item specific for bridges, so that
even bridged networks could have longer names. please consider. maybe in
another patch.
--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
