Dan Kenigsberg has posted comments on this change. Change subject: Added iSER support enabled with a configuration option. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 1892: # FIXME: remove this call when iface selection is in higher interface no need to have this FIXME twice Line 1908: def _checkIscsiIface(self, conDef, conObj, conTypeId): Please find a better name for this function, and give a little docstring telling why it does what it does. -- To view, visit http://gerrit.ovirt.org/2636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roi Dayan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Roi Dayan <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
