Ayal Baron has posted comments on this change. Change subject: fix circular reference of storage pool ......................................................................
Patch Set 2: I would prefer that you didn't submit this Question is can't we just pass a weakref to self._upgradeCallback to avoid creation of the circular reference to begin with. e.g. self.domainMonitor.onDomainConnectivityStateChange.register(weakref.ref(self._upgradeCallback)) (but need to see how to handle unregister in this case). On the face of it, it looks much simpler this way... -- To view, visit http://gerrit.ovirt.org/3242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2993b0ad8d85898ca86008f7056973ff493e8de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
