Dan Kenigsberg has posted comments on this change. Change subject: Make outOfProcess.py confrom to pep8 ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) -1 for visibility .................................................... File vdsm/storage/outOfProcess.py Line 121: attr = _ModuleWrapper(mod_os.path, self._processPool) not sure I'm crazy about this change: why add a once-used variable, and with a meaningless name? -- To view, visit http://gerrit.ovirt.org/3489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dd69ab1fc34d86fcfec45f0780d2efcec1fdde8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
