Gal Hammer has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 5: (8 inline comments)
....................................................
File vdsm/API.py
Line 408: def guestHibernate(self, state='disk'):
The name "hibernate" for the function is already un used by the "hibernate"
function.
Dan rejected my offer to add the S4 feature the existing hibernate function.
The values are defined in the vdsClient.py file.
....................................................
File vdsm/BindingXMLRPC.py
Line 330: def vmGuestHibernate(self, vmId, state='disk'):
Like the one on line 326?
Line 330: def vmGuestHibernate(self, vmId, state='disk'):
See vdsClient.py for the allowed values.
The name state come from the Windows' API SetSystemState that put the guest
into S4.
Line 755: (self.vmGuestHibernate, 'guestHibernate'),
(self.vmHibernate, 'hibernate'), ... already in use.
....................................................
File vdsm_cli/vdsClient.py
Line 57: # Guest Hibernate
Don't you just love them? :-)
Line 59: HIBERNATE_DEFAULT = 'disk'
I don't see that API.py is used in vdsClient.py.
....................................................
File vdsm/vm.py
Line 850: return self._shutdownCommand('Powering down', int(timeout),
The casting to int was the exiting code (including the config.getint). So I saw
no reason to change it in this patch.
Line 854: def hibernate(self, state='disk'):
I just follow the same naming convernsion as other commands like shutdown (and
not guestShutdown).
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
