Igor Lvovsky has posted comments on this change. Change subject: Separate the Volume.share implementation ......................................................................
Patch Set 2: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/storage/fileVolume.py Line 212: lease_path = self._getMetaVolumePath(vol_path) meta or lease ? .................................................... File vdsm/storage/volume.py Line 265: # FIXME: specific rollback per class Is it still relevant ? Line 271: fileUtils.safeUnlink(dstPath) it's run for both block and NFS. Should we do this with oop ? Line 276: os.symlink(srcPath, dstPath) As I wrote in previous patchset, > it's run for both block and NFS. Should we do link/unlink with oop ? -- To view, visit http://gerrit.ovirt.org/3737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I965b56dc98fe2d6db3ef6f3d7efe2a7b9791b555 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
