Dan Kenigsberg has posted comments on this change. Change subject: Add caps test ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) minor comments, thanks! .................................................... File tests/capsTests.py Line 33: dir = os.path.split(testPath)[0] why use testrunner? __file__ is just as good, no? btw, "dir" is a python builtin. it might be better to coose another name. .................................................... File tests/Makefile.am Line 32: capsTests.py please keep sorted (hooksTest was out of order, too). -- To view, visit http://gerrit.ovirt.org/3888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
