Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Template relink refactored. ......................................................................
Patch Set 12: I would prefer that you didn't submit this (5 inline comments) mainly minor murmurs. .................................................... File vdsm/storage/image.py Line 382: This function assumes that dom is backup dom and that template image is s/dom is/destDom/ Line 398: relinkImgs = tuple(img for img in tImgs if img != templateImage) isn't this a complex way to write relinkImgs = tuple(tImage[1:]) ? Line 400: # Assumed that the new replace template was already created I cannot understand the English here. Line 401: # All the relevant images and template namespaces should be locked "this function assumes that all relevant images and template namespaces are locked" is clearer. Line 404: oop.getProcessPool(destDom.sdUUID).os.link(os.path.join(self.repoPath, destDom.sdUUID, sd.DOMAIN_IMAGES, templateImage, volUUID), tLink) ELONGLINE -- To view, visit http://gerrit.ovirt.org/3467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I087fc777e202088615c82be1a88fcde15b846628 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
