Zhou Zheng Sheng has posted comments on this change. Change subject: Clean the RHEVM parser help in deployUtil.py.in ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm_reg/deployUtil.py.in Line 1467 I think changing the command option name and function name can be very confusing to users. Command option and function names ought to be stable between releases and different engine setup. Can we just remove the "rhevm" from the name? -- To view, visit http://gerrit.ovirt.org/3838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
