Bing Bu Cao has posted comments on this change. Change subject: Make scratchpad/before_vm_start.py compliant to pep8 ......................................................................
Patch Set 1: (2 inline comments) .................................................... File Makefile.am Line 47: vdsm_hooks/scratchpad/before_vm_start.py \ Sort the list .................................................... File vdsm_hooks/scratchpad/before_vm_start.py Line 119: (must start with /)\n' % path) Why not keep using double ' ' instead of \ ? -- To view, visit http://gerrit.ovirt.org/4578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie160109de403b45bd1ca78faecf8140caadc2216 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
