Dan Kenigsberg has posted comments on this change. Change subject: Remove the effect of other parameters on configure_sysctl ......................................................................
Patch Set 2: (2 inline comments) Do we really want this code in Vdsm? Why was /etc/sysctl.conf faulty to begin with? .................................................... Commit Message Line 11: than those of vdsm can't not configured corrcectly. So this this sounds like someone else's bug - why should we worry about it in vdsm? .................................................... File vdsm/vdsmd.init.in Line 448: [ "$ratio" == "5" ] && [ "$bg_ratio" == "2" ] writing "5" twice seems like a bad idea (if someone ever wants to change it to 7, he should do it in two places). -- To view, visit http://gerrit.ovirt.org/4865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d9f917a4abfb6952fb9fdd6a9c0e12751ecd061 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Wenyi Gao <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
