Dan Kenigsberg has posted comments on this change. Change subject: Close and remove the temporary file before raising a exception ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/multipath.py Line 116: supported state. The original configuration, if any, is saved arghh, this whole function was born in sin. it should not be called by a running vdsm, only on installation (maybe as a vdsm-tool verb). Line 121: f.write(MPATH_CONF_TEMPLATE) a more complete solution for this would be to use with tempfile.NamedTemporaryFile() as f: -- To view, visit http://gerrit.ovirt.org/4885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93eafbcf78805669596258b3579ee49cc1b79360 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
