Dan Kenigsberg has posted comments on this change. Change subject: tests: add netinfo test for intToAddress() function ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) .................................................... File tests/netinfoTests.py Line 54: num = [0, 1, 16777344, 16777408, 4294967295] I think that a dictionary would be clearer than two lists, but it's fine, too. -- To view, visit http://gerrit.ovirt.org/5339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865311cb0bac338a05513b7946c11326be5047af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
