Dan Kenigsberg has posted comments on this change. Change subject: avoid _blockstatsParses throw exception when lacking some fields ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) we could take this, but I would very much prefer that we just start using http://libvirt.org/html/libvirt-libvirt.html#virDomainBlockStatsFlags instead of parsing json ourselves. _blockstatsParses was a hack since libvirt did not support latency reports at the time. note that we can assume that all our VM supports latency reports, no need to start querying libvirt and qemu. .................................................... Commit Message Line 7: avoid _blockstatsParses throw exception when lacking some fields please mention it's in libvirtvm - I almost forgot what it was. -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
