Ayal Baron has posted comments on this change. Change subject: Add the async kwarg to acquireHostId ......................................................................
Patch Set 13: (1 inline comment) .................................................... File vdsm/storage/safelease.py Line 81: def acquireHostId(self, hostId, async=False): why do you have a default value at all levels? (here and sd). Seems like one should go? -- To view, visit http://gerrit.ovirt.org/4392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f8cf540f262a9c2da795a97acabc011b55e0dd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
