Ayal Baron has posted comments on this change. Change subject: Monitor the host id in domainMonitor ......................................................................
Patch Set 15: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/storage/domainMonitor.py Line 31: "vgMdFreeBelowThreashold", "hasHostId") you could align the lines here to comply with pep8 Line 95: # stopMonitor doesn't stop until the thread exists. s/exists/exits/ s/stopMonitor/stopMonitoring/? Line 144: if nextStatus.valid and nextStatus.hasHostId is False: why isn't this done after emiting the state change event? .................................................... File vdsm/storage/sp.py Line 681: for sdUUID in monitoredDomains: why isn't this done inside stopMonitoring (inside domainMonitor.py) -- To view, visit http://gerrit.ovirt.org/3929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c33ecdc2cd21c5afb445a339f400bc990b93998 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
