Ayal Baron has posted comments on this change. Change subject: Adding the status field to getDeviceList info. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/storage/lvm.py Line 626: #The device is created with the new parameters. comment seems redundant here Line 642: def _initpvs_removeHolders(): missing empty line above Line 750: unusedDevs, usedDevs, rc, out, err = _initpvsTest(devs, metadataSize) why separate _initpvsTest out? Line 800: pvCreateMode = True if force == "True" else False this should be parsed at API.py -- To view, visit http://gerrit.ovirt.org/5515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af6628a29bb597cf46b57a2b439e1b950bef9ab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
