Dan Kenigsberg has posted comments on this change.
Change subject: Handle bond properly if connectivity check fail.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 1068: # keep dict {network:explicitBond} to be able remove
explicitBond? or implicit? what did you mean?
Line 1073: networksAdded = {}
I cannot say that I like the over-usage of of the same variable for two things.
True/False here tells nothing about the meaning of the value.
I'd prefer another list (or dictionary) of "netsWithNewBonds".
--
To view, visit http://gerrit.ovirt.org/5712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bb04f6f3b8d5cdbfd9af8904570af071af6d4f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
