Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File vdsm-tool/base.py
Line 47: def call_init_function(*args, **kwargs):
In that case you could also use:
if not args:
But function is a required argument that can be handled at python level.
Absence implies a bug that will now only show up in logs.
Line 59: cmd2 += ' '.join(args)
How is it optional?
kwargs = {'a': 'b'}
args = ('x', 'y')
This will result in:
cmd2 = 'a=bx y'
While you would expect:
cmd2 = 'a=b x y'
--
To view, visit http://gerrit.ovirt.org/5264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1be737adce28e9ca532aa454e7f0a060947589e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
