Shu Ming has posted comments on this change.
Change subject: BZ#837443: remove bridge before add VDSM bridge
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 757: return
I think the original code will raise the exception when the if condition
matches. So the code after change should like this:
if network not in _netinfo.networks
logging,info()
if network in netinfo.bridges():
configWriter.removeBridge(network)
return
else
raise ConfigNetworkError(ne.ERR_BAD_BRIDGE, ...)
That mean neither not in libvirt data base nor in host should raise an
exception.
--
To view, visit http://gerrit.ovirt.org/6016
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2842db371483225042d511c6495df1bc5047de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
