Mark Wu has posted comments on this change. Change subject: MOM Integration ......................................................................
Patch Set 11: (2 inline comments) .................................................... File vdsm/MOM.py Line 30: class momThread(threading.Thread): we can't use the name mom.py, because it's the name of the python module MOM provides. If using mom.py, it will fail to import mom /usr/lib/python2.7/site-packages/mom The original file name is vdsmMOM.py or vdsMOM.py. As you mentioned before, the prefix is useless because it's in vdsm project. I didn't figure out a better name than MOM.py. If you have any suggestion, I will change it. Thanks! Line 44: ret['ksmState'] = stats['ksm_run'] Thanks for pointing out it! -- To view, visit http://gerrit.ovirt.org/2367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
