Ayal Baron has posted comments on this change. Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 21: Looks good to me, approved (1 inline comment) Please note inline comment .................................................... File vdsm/storage/blockVolume.py Line 290: if mysd.hasVolumeLeases(): this is to initialize the lease. is there any problem doing this on a V1/V2 SD? if not, would that matter when upgrading the domain? (make upgrade faster perhaps?) if it makes no difference or even improves things then I wouldn't limit this to V3 domains. -- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
