Federico Simoncelli has posted comments on this change. Change subject: Remove the unused nocache option ......................................................................
Patch Set 17: (2 inline comments) .................................................... File vdsm/storage/blockVolume.py Line 685: return out This method needs to be fixed in multiple places, for example also the find/split calls. I'll add these fixes to another patch to leave this one just to deal with the nocache option. Line 695: def setMetadata(self, metaarr, metaid=None): I'll address this in the new patch too. -- To view, visit http://gerrit.ovirt.org/3747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
