Dan Kenigsberg has posted comments on this change. Change subject: adding handling EINTR to poll to make it more robust ......................................................................
Patch Set 6: I would prefer that you didn't submit this (2 inline comments) few comments within. still, I would appreciate if this is sent for review on libvir-list before taken into here. .................................................... File vdsm/libvirtev.py Line 221: # Deduct 20ms, since schedular timeslice no need to revert to "schedular" here. Line 229: if e.errno != errno.EINTR: there is no select.error.errno data member. this would explode on EINTR while in poll. I do not see a way around the v[0] trick you've used earlier. -- To view, visit http://gerrit.ovirt.org/5113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie367e193cbf4b76d352d57f3d4ef55fdf45f2fd2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel P. Berrange <berra...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Xu He Jie <x...@linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
